fix: env columns hard to distinguish in compare view#7250
Open
talissoncosta wants to merge 3 commits intomainfrom
Open
fix: env columns hard to distinguish in compare view#7250talissoncosta wants to merge 3 commits intomainfrom
talissoncosta wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
bot
added
the
front-end
Adds a left border and padding to the right environment column (header and rows) so the segment override icon no longer sits flush against the next column. Closes #7249 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The segment and identity override icons were rendered after the value, which placed them at the right edge of the column — visually colliding with the next environment in the comparison view. Move them to before the value (next to the toggle) so they belong with the env-specific controls and stay clear of column boundaries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
talissoncosta
force-pushed
the
fix/compare-env-divider-7249
branch
from
6281718 to
04669d5
Compare
Replace bare text with the EmptyState component — consistent with the pattern used across charts and other empty states. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
talissoncosta
changed the title
talissoncosta
changed the title
Contributor
Docker builds report
|
talissoncosta
changed the title
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression16 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #7249
In the environment comparison view, the segment override icon (pie icon) sat flush against the next environment's column, making it hard to visually separate where one environment ends and the next begins.
This PR adds a left border and small padding to the right environment column (both header and rows) so the boundary between environments is clear.
How did you test this code?